New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support menuitemcheckbox/menuitemradio roles in toBeChecked #266
Comments
Looking at the spec of |
It's probably best to leverage |
Great idea. If it's fine to add the dependency, then the check could probably be implemented similar to the way it is used in |
+1 to this feature request, and +1 to using something like
I'd say that, unless it becomes cumbersome while implementing this to achieve it, it'd be nice if we can preserve that bit of functionality. At worse we can discuss and decide in the context of the PR when someone jumps on implementing this. |
I've submitted PR #267. Happy to incorporate feedback. |
🎉 This issue has been resolved in version 5.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Describe the feature you'd like:
According to the spec
menuitemcheckbox
andmenuitemradio
both requirearia-checked
attributes.I think it would be nice to be able to write:
Suggested implementation:
Add
menuitemcheckbox
andmenuitemradio
to the allowed roles in the matcher.Describe alternatives you've considered:
So far, I was only able to use low level matchers like
toHaveAttribute('aria-checked', 'true')
.Teachability, Documentation, Adoption, Migration Strategy:
The roles would need to be added to list of allowed roles mentioned in the readme and the error messages.
Happy to prepare a PR.
The text was updated successfully, but these errors were encountered: