fix: Updates deprecated matchers info #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 614 615 +1
Branches 225 225
=========================================
+ Hits 614 615 +1
Continue to review full report at Codecov.
|
eps1lon
approved these changes
Jun 11, 2021
|
🎉 This PR is included in version 5.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
exah
reviewed
Jun 21, 2021
|
|
||
| // See algoritm: https://www.w3.org/TR/accname-1.1/#mapping_additional_nd_description | ||
| export function toHaveDescription(htmlElement, checkWith) { | ||
| deprecate( | ||
| 'toBeInTheDOM', |
This was referenced May 24, 2024
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Properly deprecates
toHaveDescriptionin favour oftoHaveAccessibleDescription. This PR also updates the README on other deprecation-related info (e.g.toBeEmptywas deprecated, but it was not reflected in the README).While this gets reviewed and merged, I'll update the type definitions in
DefinitelyTyped.Pinging various reviewers, but only one is enough. Thanks in advance.
Checklist: