import parse directly from css #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will avoid having to access `fs` which will break in browser environments
nickmccurdy
approved these changes
Nov 2, 2021
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 620 620
Branches 227 227
=========================================
Hits 620 620
Continue to review full report at Codecov.
|
|
@all-contributors add @yannbf for code |
|
I've put up a pull request to add @yannbf! 馃帀 |
|
馃帀 This PR is included in version 5.15.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
Looks Identical to: testing-library/jasmine-dom#8 - which was the change for Jasmine - so seems good! 馃憤 thanks for the @ :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone! Thanks for this incredible library 馃寛
What:
At Storybook we are developing an addon that will allow developers to run interaction tests directly in the browser, using testing library. We'd also love to include the matcher extenders so that developers can use the assertions from
jest-dom/extend-expect, however importing things directly fromcssresult in the following failure:Module not found: Error: Can't resolve 'fs'This is an issue that happened as well in the
testing-library/jasmine-dompackage and was addressed with the exact same fix as this PR: testing-library/jasmine-dom#8Why:
These changes would allow this library to run in the browser without breaking
How:
Given that the library only needs
cssParse, there is no need to import it from the root of the package. Importing it from the root makes other files be imported as well, which results in the error mentioned above.Checklist: