Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulnerability fix: upgrade @adobe/css-tools to v4.3.2 #553

Merged
merged 2 commits into from Dec 27, 2023

Conversation

gaurav-bhardwaj-ind
Copy link
Contributor

What:

This PR bumps @adobe/css-tools to version 4.3.2

Why:
There is an existing advisory on version 4.3.1
GHSA-prr3-c3m5-p7q2

How:

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

@gaurav-bhardwaj-ind gaurav-bhardwaj-ind changed the title Upgrade @adobe/css-tools to v4.3.2 for getting rid of vulnerabilities vulnerability fix: upgrade @adobe/css-tools to v4.3.2 Dec 1, 2023
Copy link

@ryan-james-smith ryan-james-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes made in the css-tools 4.3.2 commit (adobe/css-tools@1d90dea) their are no breaking changes.
Thus the suggested change from 4.3.1 to 4.3.2 causes no problem but does fix a vulnerability.

@unandreshevia
Copy link

What is holding the team back from reviewing this PR and and having it merged? It's been 2 weeks already since it has been sent.

@mnlfischer
Copy link

Hey @nickmccurdy, hope your are doing well! Can we help here with something?

@guzhongren

This comment was marked as off-topic.

@jbouder
Copy link

jbouder commented Dec 19, 2023

Any updates on this?

@bledeabogdan
Copy link

Is there something blocking you from merging and releasing this?

@guitrusted
Copy link

guitrusted commented Dec 27, 2023

Hey team, I know you all are probably very busy, but this PR looks a bit important since it's related with a security issue. Could any of you please merge this PR as soon as possible?

cc @gnapse @nickmccurdy

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7b7c6a) 100.00% compared to head (cd3ad6a) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          668       668           
  Branches       252       254    +2     
=========================================
  Hits           668       668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnapse gnapse enabled auto-merge (squash) December 27, 2023 14:05
@gnapse gnapse merged commit b64b953 into testing-library:main Dec 27, 2023
7 checks passed
Copy link

🎉 This PR is included in version 6.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants