Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for maintainers #31

Closed
kentcdodds opened this issue Jul 25, 2020 · 8 comments
Closed

Call for maintainers #31

kentcdodds opened this issue Jul 25, 2020 · 8 comments

Comments

@kentcdodds
Copy link
Member

Is anyone interested in helping maintain this project. The primary maintainer is no longer able to maintain it.

@brunohkbx
Copy link
Collaborator

I'd love to help maintain this lib 😃

@kentcdodds
Copy link
Member Author

Thanks so much for your help! I've added you as a collaborator on the project. Maintaining this project is similar to React Testing Library, so please make sure that you review React Testing Library's other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

Also, if you feel like the PRs you've made are ready to go feel free to merge them, just make sure you use the "Squash and merge" feature so you can reword the commit message so the automation tools will release it with the proper version.

@thymikee
Copy link
Collaborator

Happy to help as well :)

@kentcdodds
Copy link
Member Author

Awesome. Note that you don't have to use the existing automation tools as they are if you don't like. Feel free to change things up however you like.

@brunohkbx brunohkbx pinned this issue Sep 7, 2020
@mitramejia
Copy link

mitramejia commented Jul 9, 2021

@kentcdodds @brunohkbx would love to help!

@mdjastrzebski
Copy link
Collaborator

@kentcdodds heads up that we are working on migrating Jest Native matchers to inside React Native Testing Library package: callstack/react-native-testing-library#1468.

Since RNTL is the primary consumer of Jest Native matchers (except perhaps for hardcode users of React Test Renderer) it would benefit the users by:

  • brining Jest Native matchers into well maintained project
  • aligning JN with RNTL implementation in regard of RN env simulation (both RNTL & JN do not use actual React Native renderer but React Test Renderer and simulate the RN env)
  • removing potential version discrepancy between RNTL and JN

This package would be kept as-is for legacy users. We would add deprecation notice and link to migration docs. Additionally, we will provide a gradual migration path where matches from this package can be imported in alternative way as legacy_toXX, so that users can use both JN and RNTL matchers at the same time.

@kentcdodds
Copy link
Member Author

That's fine with me @mdjastrzebski 👍 As I'm not a user of the project I don't really have a place to have an opinion, but thanks for the heads up.

@mdjastrzebski
Copy link
Collaborator

Closing as resolved due to migration of matchers to React Native Testing Library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants