Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer v17 compatibility #77

Closed
swissspidy opened this issue Aug 31, 2022 · 5 comments
Closed

Puppeteer v17 compatibility #77

swissspidy opened this issue Aug 31, 2022 · 5 comments

Comments

@swissspidy
Copy link

In puppeteer/puppeteer#8844, which was released as part of Puppeteer v17, the execution context has been marked internal, so this access is no longer possible.

I see it's being used twice here:

.executionContext()

.executionContext()

@swissspidy
Copy link
Author

The new recommended approach in v17.1.0 is to use ElementHandle.frame() directly, see puppeteer/puppeteer#8875. It should be released soon.

@patrickhulce
Copy link
Collaborator

Thanks for the note @swissspidy! We'll fix it 👍

@patrickhulce
Copy link
Collaborator

fix is up at #78 but getting this to work in a non-breaking way with typescript is...tricky :)

help with tests is welcome

@georgehb
Copy link
Contributor

georgehb commented Feb 8, 2023

Is there any update on this?

If getting the types to work on both new and old versions of puppeteer is too much hassle, could the solution not be to drop support for old versions of puppeteer and release the changes as a major version bump?

@patrickhulce
Copy link
Collaborator

fixed by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants