Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate @testing-library/preact-hooks #17

Open
MichaelDeBoey opened this issue May 26, 2022 · 3 comments
Open

Deprecate @testing-library/preact-hooks #17

MichaelDeBoey opened this issue May 26, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented May 26, 2022 •
edited

Now that testing-library/preact-testing-library#56 is merged, this library can be deprecated

CC/ @testing-library/preact-hooks
@JoviDeCroock
Copy link
Member

JoviDeCroock commented May 26, 2022 •
edited

I don't think so, even for react they are kept around, let's not deviate too hard 😅 @testing-library/preact-hooks does a lot more as well in terms of Suspense and so on

@nickmccurdy
Copy link
Member

Any more opinions on this? I think we should at least add a blurb to the readme like we did for React Testing Library.

@nickmccurdy nickmccurdy mentioned this issue Sep 25, 2022
Closed
@nickmccurdy nickmccurdy added the documentation Improvements or additions to documentation label Sep 25, 2022
@kentcdodds
Copy link
Member

An explanation in the README makes sense to me. If this library does more than the other, maybe those features should be added to the other so this can be deprecated.

I don't have any basis for opinion here. Just some thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickmccurdy @kentcdodds @MichaelDeBoey @JoviDeCroock