Capture all results a rendered hook produces. #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 126 128 +2
Branches 23 24 +1
=========================================
+ Hits 126 128 +2
Continue to review full report at Codecov.
|
Closed
pr/result-history-docs
|
I want to hold off on this until after #502 so I can test semantic release (I'll amend my commit messages first). |
mpeyper
added a commit
that referenced
this pull request
Dec 7, 2020
There was an issue with a minor release, so this manual-releases.md change is to release a new minor version. Reference: #496
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461
What:
Make all results a rendered hook produces available to tests for assertions.
Why:
To test that initial states (prior to effects running) or other intermediate states were produced as expected. There has been some suggestion this could be useful for testing SSR scenarios as well.
How:
When the result gets update it we push it into an array and surface it through the
resultcontainer returned fromrenderHookasresult.all.Checklist: