Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] update default renderer's error message. #547

Merged
merged 1 commit into from Jan 18, 2021

Conversation

joshuaellis
Copy link
Member

What:

Improve error message from our auto-detect-renderer function for users who are bundling.

Why:

Based on the feedback from #544

How:

Update the err msg & correct the test.

Checklist:

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #547 (892cdfe) into master (d980fc0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #547   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          210       210           
  Branches        23        23           
=========================================
  Hits           210       210           
Impacted Files Coverage Δ
src/pure.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d980fc0...892cdfe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant