Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make library compatible with Node 8 #587

Merged
merged 1 commit into from Mar 29, 2021

Conversation

yoniholmes
Copy link
Contributor

What:

Tweak to make library compatible with Node 8

Why:

I'm using your library in an environment which for reasons can only run on Node 8.

How:

A minor syntax change ensures the library works in Node 8.

Checklist:

  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #587 (fe645b7) into master (3d2e0d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #587   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          219       219           
  Branches        29        29           
=========================================
  Hits           219       219           
Impacted Files Coverage Δ
src/pure.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2e0d8...fe645b7. Read the comment docs.

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit ef2daaf into testing-library:master Mar 29, 2021
@yoniholmes
Copy link
Contributor Author

yoniholmes commented Mar 29, 2021 via email

@github-actions
Copy link

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants