Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for React 18 #1031

Merged
merged 11 commits into from Mar 31, 2022
Merged

feat: Add support for React 18 #1031

merged 11 commits into from Mar 31, 2022

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 30, 2022

BREAKING CHANGE: Drop support for React 17 and earlier. We'll use the new createRoot API by default which comes with a set of changes while also enabling support for concurrent features.
To can opt-out of this change by using render(ui, { legacyRoot: true } ). But be aware that the legacy root API is deprecated in React 18 and its usage will trigger console warnings.

What:

Support React 18 in our stable release

Why:

React 18 stable was released yesterday

How:

Squash alpha into main to preserve.

Checklist:

eps1lon and others added 9 commits September 13, 2021 10:49
BREAKING CHANGE: If you have React 18 installed, we'll use the new [`createRoot` API](reactwg/react-18#5) by default which comes with a set of [changes while also enabling support for concurrent features](reactwg/react-18#4).
To can opt-out of this change by using `render(ui, { legacyRoot: true } )`. But be aware that the legacy root API is deprecated in React 18 and its usage will trigger console warnings.
Co-authored-by: Philipp Fritsche <ph.fritsche@gmail.com>
BREAKING CHANGE: Drop support for React < 18.0.0-rc.1
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 519a8c4:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1031 (519a8c4) into main (0c4aabe) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1031   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          142       169   +27     
  Branches        30        35    +5     
=========================================
+ Hits           142       169   +27     
Flag Coverage Δ
experimental 100.00% <100.00%> (?)
latest 100.00% <100.00%> (?)
next 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/act-compat.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/pure.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4aabe...519a8c4. Read the comment docs.

@eps1lon eps1lon changed the title feat: Add support for React 18 (#937) feat: Add support for React 18 Mar 30, 2022
@eps1lon eps1lon marked this pull request as ready for review March 30, 2022 15:22
@eps1lon eps1lon requested a review from kentcdodds March 30, 2022 15:22
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this 👍

Merge away! Thanks!

@eps1lon eps1lon merged commit ccd8a0d into main Mar 31, 2022
@eps1lon eps1lon deleted the alpha branch March 31, 2022 04:55
@github-actions
Copy link

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants