Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specify a non-* version for @types/react-dom #1040

Merged
merged 2 commits into from Apr 11, 2022

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Apr 11, 2022

What: fixes #1039

Why: Updating to react@18 (including types) is broken when using yarn because it picks the wrong version

How: Testing

Checklist:

  • N/A - Documentation added to the
    docs site
  • N/A - Tests
  • N/A - TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 76cda65:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@eps1lon eps1lon changed the title Specify a non-* version for @types/react-dom fix: Specify a non-* version for @types/react-dom Apr 11, 2022
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to switch to peerDependencies (see facebook/react#24304 (comment)) but this is a step in the right direction. Thanks!

@Nokel81
Copy link
Contributor Author

Nokel81 commented Apr 11, 2022

Thanks, in the meantime I did the nuclear option...

The CI errors seem to imply that there should be some things that need fixing, shall I update the PR to do that too?

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1040 (76cda65) into main (93bc2c8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1040   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          169       169           
  Branches        33        33           
=========================================
  Hits           169       169           
Flag Coverage Δ
experimental 100.00% <ø> (ø)
latest 100.00% <ø> (ø)
next 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bc2c8...76cda65. Read the comment docs.

@eps1lon eps1lon merged commit 2a889e8 into testing-library:main Apr 11, 2022
@Nokel81 Nokel81 deleted the patch-1 branch April 11, 2022 18:03
@eps1lon
Copy link
Member

eps1lon commented Apr 11, 2022

@all-contributors add @Nokel81 for bug and code

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @Nokel81! 🎉

@github-actions
Copy link

🎉 This PR is included in version 13.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@simkessy
Copy link

This is broken, resulting in:


    Cannot find module 'react-dom/client' from '../../../node_modules/@testing-library/react/dist/pure.js'

    Require stack:
      /home/node_modules/@testing-library/react/dist/pure.js
      /home/node_modules/@testing-library/react/dist/index.js
      src/components/review_details/Formatters/LinkFormatter.test.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typings for v13.0.0 are broken
3 participants