Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export RenderHookOptions type #1062

Merged
merged 1 commit into from May 3, 2022

Conversation

mboettcher
Copy link
Contributor

@mboettcher mboettcher commented May 3, 2022

Hi - @testing-library/react-hooks exported the type RenderHookOptions, it would be great if it could be exported here as well since it is helpful when we write wrappers around renderHook (e.g. I have a wrapper to enable react-router).

What:

Export RenderHookOptions

Why:

It's helpful when writing own extensions to renderHook.

How:

added an export ;)

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • TypeScript definitions updated
  • Ready to be merged

RenderHookOptions should be exported as well
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77a25c9:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@eps1lon eps1lon changed the title Export RenderHookOptions type feat: Export RenderHookOptions type May 3, 2022
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@all-contributors add @mboettcher for code

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1062 (77a25c9) into main (9171163) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1062   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          181       181           
  Branches        34        34           
=========================================
  Hits           181       181           
Flag Coverage Δ
experimental 100.00% <ø> (ø)
latest 100.00% <ø> (ø)
next 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9171163...77a25c9. Read the comment docs.

@eps1lon eps1lon merged commit 46b28ad into testing-library:main May 3, 2022
@eps1lon
Copy link
Member

eps1lon commented May 3, 2022

@all-contributors add @mboettcher for code

1 similar comment
@eps1lon
Copy link
Member

eps1lon commented May 3, 2022

@all-contributors add @mboettcher for code

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @mboettcher! 🎉

@github-actions
Copy link

github-actions bot commented May 3, 2022

🎉 This PR is included in version 13.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mboettcher mboettcher deleted the patch-1 branch May 4, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants