feat: Flush microtasks in cleanup #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've got a few breaking changes to make in DOM Testing Library that we really need to push out. We should do all of this at the same time. Hopefully will get it done next week. |
|
🎉 This PR is included in version 10.0.0-beta.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kentcdodds
pushed a commit
that referenced
this pull request
Mar 4, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
timswalling
added a commit
to timswalling/DefinitelyTyped
that referenced
this pull request
Mar 23, 2020
As of testing-library/react-testing-library#519 `cleanup` is an async function.
Merged
8 tasks
orta
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Mar 27, 2020
As of testing-library/react-testing-library#519 `cleanup` is an async function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING:
cleanupis now async.What:
Flushes microtasks (introduced in #514) in cleanup instead of afterEach
Why:
Flushing microtask is not available for users of the
/purebuild.How:
Move logic from index#afterEach into pure#cleanup
Checklist:
docs site