Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 8 #575

Closed
kentcdodds opened this issue Jan 21, 2020 · 5 comments · Fixed by #576, guram21/counter-app#1 or guram21/counter-app#3
Closed

Drop Node 8 #575

kentcdodds opened this issue Jan 21, 2020 · 5 comments · Fixed by #576, guram21/counter-app#1 or guram21/counter-app#3
Labels
BREAKING CHANGE This change will require a major version bump released on @beta released

Comments

@kentcdodds
Copy link
Member

Because it's no longer LTS.

@kentcdodds kentcdodds added the BREAKING CHANGE This change will require a major version bump label Jan 21, 2020
@thomasgrz
Copy link

thomasgrz commented Jan 23, 2020

This would be resolved by updating to >= Node 10, correct? Happy to submit a PR for this as this is a project I use fairly frequently. Attempted to submit a PR the other day but received a 403 access denied when attempting to git push origin pr/update-node. I assume there may be some security settings on the repo to disallowed it?

@eps1lon
Copy link
Member

eps1lon commented Jan 23, 2020

I assume there may be some security settings on the repo to disallowed it?

You usually set the origin to the repo you own and upstream to the fork. See https://gist.github.com/Chaser324/ce0505fbed06b947d962 or https://help.github.com/en/github/getting-started-with-github/fork-a-repo.

@thomasgrz thomasgrz mentioned this issue Jan 23, 2020
1 task
@thomasgrz
Copy link

@eps1lon thank you! I believe I properly (?) submitted the PR thanks to your guidance 👍 .

kentcdodds added a commit that referenced this issue Mar 4, 2020
kentcdodds added a commit that referenced this issue Mar 4, 2020
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
@kentcdodds
Copy link
Member Author

🎉 This issue has been resolved in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kentcdodds added a commit that referenced this issue Mar 4, 2020
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this issue Mar 12, 2020
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this issue Mar 12, 2020
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this issue Mar 12, 2020
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
@kentcdodds
Copy link
Member Author

🎉 This issue has been resolved in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @beta released
Projects
None yet
3 participants