Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node 8 support #576

Merged
merged 3 commits into from Mar 4, 2020
Merged

Drop Node 8 support #576

merged 3 commits into from Mar 4, 2020

Conversation

thomasgrz
Copy link

@thomasgrz thomasgrz commented Jan 23, 2020 •
edited by eps1lon

What:
Updating the engine to Node v.10.

Why:
Node v.8 no longer has LTS. Closes #575

How:
Updating the engine field in package.json & .travis.yml respectively.

Checklist:

  • [N/A] Documentation added to the
    docs site
  • [N/A] Tests
  • [N/A] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 23, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5110fde:

Sandbox Source
strange-grothendieck-9urri Configuration
compassionate-maxwell-mfjes Configuration

@codecov
Copy link

codecov bot commented Jan 23, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (beta@9d0738f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             beta   #576   +/-   ##
=====================================
  Coverage        ?   100%           
=====================================
  Files           ?      3           
  Lines           ?     95           
  Branches        ?     15           
=====================================
  Hits            ?     95           
  Misses          ?      0           
  Partials        ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0738f...5110fde. Read the comment docs.

kentcdodds
kentcdodds reviewed Jan 23, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this'll take a bit before we merge because we want to batch all the breaking changes into one. Hopefully that'll happen pretty soon.

@eps1lon eps1lon added the BREAKING CHANGE This change will require a major version bump label Jan 23, 2020
@eps1lon eps1lon changed the title update node engine to version 10 Drop Node 8 support Jan 23, 2020
rhoskal
rhoskal reviewed Feb 10, 2020
View reviewed changes
.travis.yml Outdated
- '10'
- '12'
- '13'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js folks don't recommend v13 for production since it wont be promoted to LTS. Maybe both just v10 and v12 will suffice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the testing environment not the production environment. If this adds too much work we can remove it. Otherwise it seems useful to monitor support.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it node, so it's just the latest version of Node.js

@kentcdodds kentcdodds changed the base branch from master to beta March 4, 2020 19:18
kentcdodds
kentcdodds approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you!

@kentcdodds kentcdodds merged commit 081e8b6 into testing-library:beta Mar 4, 2020
kentcdodds added a commit that referenced this pull request Mar 4, 2020
@kentcdodds
fix(node): drop Node 8 support (#576)
e743faf 
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this pull request Mar 4, 2020
@kentcdodds
fix(node): drop Node 8 support (#576)
5a5731a 
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix(node): drop Node 8 support (#576)
a6e104b 
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix(node): drop Node 8 support (#576)
c36080c 
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix(node): drop Node 8 support (#576)
9b0f9c7 
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix(node): drop Node 8 support (#576)
fccc2cf 
Closes #575

BREAKING CHANGE: This release drops support for Node 8. Upgrade to Node 10 or greater.
@snyk-bot snyk-bot mentioned this pull request Apr 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey left review comments

@rhoskal rhoskal rhoskal left review comments

@eps1lon eps1lon eps1lon left review comments

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Node 8
5 participants
@thomasgrz @kentcdodds @MichaelDeBoey @rhoskal @eps1lon