Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug): accept the same arguments as prettyDOM #596

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Mar 4, 2020

What: make debug accept the same args as prettyDOM

Why: Closes #580

How: Accepting additional args and forwarding them along.

Checklist:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d5fbb6:

Sandbox Source
tender-wood-ekbee Configuration
still-dew-77p9k Configuration

@kentcdodds kentcdodds merged commit 35522b1 into master Mar 4, 2020
@kentcdodds kentcdodds deleted the pr/debug-args branch March 4, 2020 19:13
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #596 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #596   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         103    103           
  Branches       15     15           
=====================================
  Hits          103    103
Impacted Files Coverage 螖
src/pure.js 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ea67b17...0d5fbb6. Read the comment docs.

@kentcdodds
Copy link
Member Author

馃帀 This PR is included in version 9.5.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow debug to accept same args at prettyDOM
1 participant