Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Node >=10 #611

Merged
merged 1 commit into from Mar 13, 2020
Merged

Conversation

NMinhNguyen
Copy link
Contributor

What: support older Node 10 versions

Why: to make the upgrade easier since there doesn't appear to be a hard requirement to use Node 10.18 (see testing-library/dom-testing-library#459 (comment)).

How: changed engines.node from >=10.18 to >=10 and updated Travis to use Node.js 10.0.0.

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f44d62:

Sandbox Source
quizzical-kepler-9dkml Configuration
relaxed-lalande-2ys1v Configuration

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #611 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #611   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          103       103           
  Branches        15        15           
=========================================
  Hits           103       103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26b8df...8f44d62. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry this got missed somehow!

@kentcdodds kentcdodds merged commit 3bc13d9 into testing-library:master Mar 13, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants