Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore this when requiring timers #644

Merged
merged 1 commit into from Apr 20, 2020
Merged

fix: restore this when requiring timers #644

merged 1 commit into from Apr 20, 2020

Conversation

just-boris
Copy link
Contributor

What:

closes #614

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests (not testable in the current setup)
  • Typescript definitions updated N/A
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c1c72d:

Sandbox Source
happy-dust-v37dj Configuration
reverent-mayer-gzeew Configuration
react-testing-library demo Issue #614

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          103       103           
  Branches        15        15           
=========================================
  Hits           103       103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f0c75...4c1c72d. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon eps1lon added the bug Something isn't working label Apr 20, 2020
@eps1lon eps1lon changed the title fix: work around issues with esm module fix: restore this when requiring timers Apr 20, 2020
@eps1lon eps1lon merged commit 59a2de1 into testing-library:master Apr 20, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto cleanup will break down testing in mocha & esm environment
3 participants