Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bring typings from DefinitelyTyped into this repo #690

Merged
merged 2 commits into from Jun 4, 2020

Conversation

samtsai
Copy link
Collaborator

@samtsai samtsai commented Jun 3, 2020

What:
Improve support of typings by bringing them into this repo instead of relying on a versioned external repo

Why:
Help with stability for consumers using typings and give a clearer understanding of what should be supported in a given version without having to reference multiple repos.

How:
Modeled after these changes in a sibling repo: testing-library/dom-testing-library#530

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

Currently this does not validate with several errors for Typescript@4.0, example:

ERROR: 6:23   expect      TypeScript@4.0 compile error:
Cannot use JSX unless the '--jsx' flag is provided.

I'm still investigating this, but if anyone knows more about dtslint I'm all 馃憘

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0d9a33:

Sandbox Source
elegant-star-vwz3u Configuration
cold-sunset-6uo84 Configuration

@@ -0,0 +1,59 @@
// TypeScript Version: 3.8
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds
Copy link
Member

Looks awesome. I don't know about the dtslint stuff, but once that's worked out I'm good to merge 馃憤 Thanks!

Add `pure.d.ts` that re-exports everything from `index.d.ts`
Turn off `whitespace` rule
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #690   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           99        99           
  Branches        15        15           
=========================================
  Hits            99        99           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c3008be...b0d9a33. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks!

@kentcdodds kentcdodds merged commit 16f2f56 into testing-library:master Jun 4, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @samtsai for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @samtsai! 馃帀

@kentcdodds
Copy link
Member

馃帀 This PR is included in version 10.1.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants