Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TS): add type defs file for pure #696

Merged
merged 3 commits into from Jun 5, 2020
Merged

fix(TS): add type defs file for pure #696

merged 3 commits into from Jun 5, 2020

Conversation

kentcdodds
Copy link
Member

Closes #695

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 013fbe9:

Sandbox Source
vigilant-lamarr-9t2l7 Configuration
autumn-microservice-1x6n9 Configuration
react-testing-library demo Issue #695
quirky-montalcini-l7w5s Issue #695

Copy link
Contributor

@NiGhTTraX NiGhTTraX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds I think pkg.files should be updated to include the new file.

pure.d.ts Outdated Show resolved Hide resolved
kentcdodds and others added 2 commits June 5, 2020 13:12
Co-authored-by: Andrei Picus <485061+NiGhTTraX@users.noreply.github.com>
@kentcdodds kentcdodds merged commit 4bd4497 into master Jun 5, 2020
@kentcdodds kentcdodds deleted the fix-ts-defs branch June 5, 2020 19:13
@kentcdodds
Copy link
Member Author

@all-contributors please add @NiGhTTraX for bugs and review

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @NiGhTTraX! 🎉

@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 10.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No type definitions for react/pure
2 participants