fix: Guard against process not being defined
#911
Conversation
Webpack 5 doesn't shim Node's process object by default anymore. Only instances of process.env.NODE_ENV are replaced statically. This means that unguarded checks of process.env will crash in browser environments (such as Karma).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7c2a78:
|
| @@ -5,7 +5,7 @@ import {cleanup} from './pure' | |||
| // this ensures that tests run in isolation from each other | |||
| // if you don't like this then either import the `pure` module | |||
| // or set the RTL_SKIP_AUTO_CLEANUP env variable to 'true'. | |||
| if (!process.env.RTL_SKIP_AUTO_CLEANUP) { | |||
| if (typeof process === "undefined" || !process.env?.RTL_SKIP_AUTO_CLEANUP) { | |||
There was a problem hiding this comment.
Does your build setup support optional chaining? I hope that's fine 馃榿
Codecov Report
@@ Coverage Diff @@
## main #911 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 140 140
Branches 26 26
=========================================
Hits 140 140
Continue to review full report at Codecov.
|
eps1lon
changed the title
process not being defined
|
@all-contributors Add @jhnns for code |
|
I've put up a pull request to add @jhnns! 馃帀 |
|
馃帀 This PR is included in version 11.2.7 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
Not needed anymore with v11.2.7+ See testing-library/react-testing-library#911
Webpack 5 doesn't shim Node's `process` object by default anymore. Only instances of `process.env.NODE_ENV` are replaced statically. This means that unguarded checks of `process.env` will crash in browser environments (such as Karma). This is a port of testing-library/react-testing-library#911
Hi all 馃憢
What:
Fixes
when @testing-library/react is being used with webpack 5 and karma.
Why:
Webpack 5 doesn't shim Node's
processobject by default anymore. Only instances ofprocess.env.NODE_ENVare replaced statically. This means that unguarded checks ofprocess.envwill crash in browser environments.How:
I was wondering if there should also be a check in
dont-cleanup-after-each.js. I decided against it since this would need to define a globalprocessobject in order to define the env variable. After all, it's the app developer's responsibility to provide a globalprocessobject in this case.Checklist:
docs site N/A