Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring sync api back for a few minor verions #1177

Open
fa93hws opened this issue Nov 9, 2023 · 2 comments
Open

Bring sync api back for a few minor verions #1177

fa93hws opened this issue Nov 9, 2023 · 2 comments
Labels
enhancement New feature or request needs assessment This needs to be looked at by a team member

Comments

@fa93hws
Copy link
Contributor

fa93hws commented Nov 9, 2023

Problem description

One breaking change introduced in v14 is that almost all api is changed to async now.
It become a nightmare to upgrade testing library now because we lots of frontend engineer works on the monorepo and it's extremely hard to get all usage changed in one go.

I think for a breaking api that has such a big impact maybe better to have a smoother migration plan?

Suggested solution

Bring the sync api back for a few minor version and decorated as deprecated. They can be removed from next major version.
So that we can upgrade first, enforce a linting rule and fix the rest progressively.

Additional context

No response

@fa93hws fa93hws added enhancement New feature or request needs assessment This needs to be looked at by a team member labels Nov 9, 2023
@ethanneff
Copy link

yeah we are still on v13 because v14 was a nightmare to migrate

@eddielee394
Copy link

Yeah, i"m in the process of doing the upgrade now on a medium sized application and it's been brutal. We have 3 other FE apps that we still have to do that I'm genuinely not looking forward to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs assessment This needs to be looked at by a team member
Projects
None yet
Development

No branches or pull requests

3 participants