Handle maxLength for userEvent.type

[klujanrosas]

This is related to #161 .
I took the liberty to implement it. I look forward to your comments or suggestions.

[codecov]

Codecov Report

Merging #185 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage    97.2%   97.24%   +0.03%     
==========================================
  Files           1        1              
  Lines         143      145       +2     
  Branches       34       35       +1     
==========================================
+ Hits          139      141       +2     
  Misses          4        4

Impacted Files	Coverage Δ
src/index.js	97.24% <100%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad9eed...0dcd8c1. Read the comment docs.

[afontcu]

LGTM! Should we also check if tests are passing when allAtOnce is false? Can't think of a reason why this would make it fail, but I'd also love to make sure it doesn't since we modified both if branches from opts.allAtOnce.

[klujanrosas]

@afontcu I also can't think of a reason why they would fail, but one can never be too cautious!

I will find some time to add those tests as well, thank you

[klujanrosas]

@afontcu sorry to bother you, could this be reviewed again?

[afontcu]

LGTM! I'll let @Gpx review and merge it :)

[kentcdodds]

Are we sure the browser doesn't continue to fire input events even though the maxlength is reached? We don't have to actually update the value, but we should make sure we fire all the same events the browser does.

[calebeby]

@kentcdodds I just tested an input with a maxlength, it looks like it only fires input events till the max length is reached.

[kentcdodds]

Cool. Are we still firing keyup/keydown events?

[calebeby]

I'm pretty sure that we should be, but I'm not sure whether it does in this PR

[klujanrosas]

@kentcdodds @calebeby that makes sense, I will update this PR so it still fires keyup/keydown events, thank you for your comments

[carlos-cne]

Hi! I arrived here because I have an input with a max-length attribute.
When I call userEvent.type(...) with a string more than max-length, it does not work and I got a string with more than max-length.

I'm testing if input.value is equal to max-length
expect(inputValue.value).toHaveLength(60);

[kentcdodds]

Hi @carlos-cne,

Yes, once this PR is updated and then merged that issue should go away.

[klujanrosas]

@Gpx @kentcdodds I've updated this to reflect what was suggested in the comments above, let me know if there's anything else that I should cover or change 🐣

[kentcdodds]

Looks good to me! Thank you so much :)

[kentcdodds]

Wait, shouldn't these all be called several times?

[klujanrosas]

not for allAtOnce: true afaik

[kentcdodds]

Oh! lol, my bad.

[kentcdodds]

Super 👍

[kentcdodds]

@all-contributors please add @klujanrosas for code and tests

[allcontributors]

@kentcdodds

I've put up a pull request to add @klujanrosas! 🎉

[Gpx]

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀