Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/allow selecting options in optgroups #196

Conversation

jordyvandomselaar
Copy link
Contributor

@jordyvandomselaar jordyvandomselaar commented Dec 17, 2019

I'm opening this PR to solve an issue where selectOptions does not work if the options are nested inside optgroup elements. I think querySelectorAll would solve this and possibly other cases where nesting could be an issue.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #196 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage    97.1%   97.14%   +0.04%     
==========================================
  Files           1        1              
  Lines         138      140       +2     
  Branches       34       34              
==========================================
+ Hits          134      136       +2     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 97.14% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d623d53...43a74d8. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thank you!

@kentcdodds kentcdodds merged commit 8ba1b15 into testing-library:master Jan 28, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @jordyvandomselaar for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @jordyvandomselaar! 🎉

@Gpx
Copy link
Member

Gpx commented Jan 28, 2020

🎉 This PR is included in version 8.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gpx Gpx added the released label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants