Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README needs to be updated for user-event #198

Closed
maheshjag opened this issue Dec 18, 2019 · 7 comments · Fixed by #200
Closed

README needs to be updated for user-event #198

maheshjag opened this issue Dec 18, 2019 · 7 comments · Fixed by #200
Labels
released

Comments

@maheshjag
Copy link
Contributor

maheshjag commented Dec 18, 2019 •
edited

The type method is async, but the documentation doesn't reflect it.
@kentcdodds
Copy link
Member

Thanks for the tip! Would you like to make a pull request?

@maheshjag
Copy link
Contributor Author

maheshjag commented Dec 19, 2019 •
edited

I tried to, but it looks like I don't have enough permissions on this project to push my branch:

ERROR: Permission to testing-library/user-event.git denied to <my user id>.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

@kentcdodds
Copy link
Member

You need to fork the project. You can watch that free video course I linked to to learn how to do that 👍

@maheshjag
Copy link
Contributor Author

Ah, okay! I usually branch off and then push the branch. Will do so when I get some time to spare.

maheshjag pushed a commit to maheshjag/user-event that referenced this issue Dec 19, 2019
fix: updated the documentation for the type method
3cfbcbe 
Fixes testing-library#198
@maheshjag maheshjag mentioned this issue Dec 19, 2019
Merged
@Gpx Gpx closed this as completed in #200 Dec 20, 2019
@Gpx
Copy link
Member

Gpx commented Dec 20, 2019

🎉 This issue has been resolved in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gpx Gpx added the released label Dec 20, 2019
@weyert
Copy link

weyert commented Dec 22, 2019

It's only async when you have set a delay though

@maheshjag
Copy link
Contributor Author

@weyert The function is defined as async, so will always return a promise irrespective of whether or not a delay is specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updated the documentation for the type method maheshjag/user-event
4 participants
@weyert @Gpx @kentcdodds @maheshjag