fix tab focus on disabled elements false positive #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 97.1% 97.18% +0.08%
==========================================
Files 1 1
Lines 138 142 +4
Branches 36 34 -2
==========================================
+ Hits 134 138 +4
Misses 4 4
Continue to review full report at Codecov.
|
|
@kandros apologies, i just saw this now, thank you for adding this! |
benmonro
approved these changes
Jan 27, 2020
|
@kentcdodds if this looks good to you can you merge plz? |
|
@all-contributors please add @kandros for code and tests |
|
I've put up a pull request to add @kandros! 🎉 |
|
🎉 This PR is included in version 8.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes a false positive that allowed the
tabfunction to focus disabled elements, which is not the browser behaviordone @
Milano