Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab with radio buttons #207

Closed
benmonro opened this issue Jan 7, 2020 · 1 comment · Fixed by #330
Closed

tab with radio buttons #207

benmonro opened this issue Jan 7, 2020 · 1 comment · Fixed by #330
Assignees
@benmonro @nickmccurdy
Labels
bug Something isn't working released

Comments

@benmonro
Copy link
Member

benmonro commented Jan 7, 2020

just discovered an issue w/ tab(). it does not account for radio buttons properly and needs to more closely resemble the browser in this respect.
@benmonro benmonro self-assigned this Jan 7, 2020
@nickmccurdy nickmccurdy added needs investigation Someone has to do research on this accuracy Improves the accuracy of how behavior is simulated bug Something isn't working and removed help wanted needs investigation Someone has to do research on this labels Jun 9, 2020
nickmccurdy added a commit that referenced this issue Jun 9, 2020
@nickmccurdy
fix(tab): Make tab respect radio groups (#207)
5fe3cfb
nickmccurdy added a commit that referenced this issue Jun 9, 2020
@nickmccurdy
fix(tab): make tab respect radio groups (#207)
361ebb7
@nickmccurdy nickmccurdy mentioned this issue Jun 9, 2020
Merged
4 tasks
nickmccurdy added a commit that referenced this issue Jun 9, 2020
@nickmccurdy
fix(tab): make tab respect radio groups (fix #207)
93da220
@nickmccurdy nickmccurdy linked a pull request Jun 9, 2020 that will close this issue
fix(tab): make tab respect radio groups (fix #207) #330
Merged
4 tasks
@nickmccurdy nickmccurdy self-assigned this Jun 9, 2020
nickmccurdy added a commit that referenced this issue Jun 9, 2020
@nickmccurdy
Merge pull request #330 from testing-library/pr/make-tab-respect-radi…
dbdefef 
…o-groups

fix(tab): make tab respect radio groups (fix #207)
@kentcdodds
Copy link
Member

🎉 This issue has been resolved in version 11.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickmccurdy nickmccurdy removed the accuracy Improves the accuracy of how behavior is simulated label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benmonro benmonro

@nickmccurdy nickmccurdy

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tab): make tab respect radio groups (fix #207) testing-library/user-event
3 participants
@benmonro @nickmccurdy @kentcdodds