Feat/toggleSelectOptions

[malcolm-kee]

resolves #180

[codecov]

Codecov Report

Merging #252 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   99.20%   99.26%   +0.05%     
==========================================
  Files           2        2              
  Lines         253      273      +20     
  Branches       65       70       +5     
==========================================
+ Hits          251      271      +20     
  Misses          2        2              

Impacted Files	Coverage Δ
src/index.js	98.88% <100.00%> (+0.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abecfa...6e31338. Read the comment docs.

[kentcdodds]

Hi @malcolm-kee,

So sorry that you put all of this work into this PR and haven't heard anything in months. I'm starting to pick up development here. Would you be interested in getting this PR updated with the latest version of the code?

If so, there are two bits of feedback:

1. I'd prefer to call this toggleSelectOption to make it more clear that it's for selects
2. Could you update the tests to use the new setup utility?

Here's an example usage:

user-event/src/__tests__/type-modifiers.js

Lines 19 to 29 in 4abecfa

	test('{esc} triggers typing the escape character', async () => {
	const {element: input, getEventCalls} = setup(<input />)
	await userEvent.type(input, '{esc}')
	expect(getEventCalls()).toMatchInlineSnapshot(`
	focus
	keydown: Escape (27)
	keyup: Escape (27)
	`)
	})

Again, I apologize for the trouble.

[malcolm-kee]

@kentcdodds no problem at all. I'll add the changes.

[kentcdodds]

This is solid! Just a few suggestions/ideas.

[kentcdodds]

Super! Thank you!

[kentcdodds]

@all-contributors please add @malcolm-kee for code, docs, and tests

[allcontributors]

@kentcdodds

I've put up a pull request to add @malcolm-kee! 🎉

[kentcdodds]

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

[malcolm-kee]

Thanks @kentcdodds !

[kentcdodds]

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀