Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Add support for ctrl click. #271

Merged
merged 1 commit into from May 12, 2020

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented May 12, 2020

We pass the init argument through so that the underlying
click event can be created with ctrlKey set to true if desired.

We pass the `init` argument through so that the underlying
click event can be created with ctrlKey set to true if desired.
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files           1        1           
  Lines         160      160           
  Branches       44       44           
=======================================
  Hits          158      158           
  Misses          2        2           
Impacted Files Coverage Δ
src/index.js 98.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bb7def...5863fc5. Read the comment docs.

@Raynos
Copy link
Contributor Author

Raynos commented May 12, 2020

I found this library from a recent blog post by @kentcdodds ( https://kentcdodds.com/blog/common-mistakes-with-react-testing-library/#using-waitfor-to-wait-for-elements-that-can-be-queried-with-find ).

This is a great library; I've added a small feature to allow testing multi-selection behavior in my app with ctrl and shift click behavior.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍👍

@kentcdodds kentcdodds merged commit 87adb56 into testing-library:master May 12, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @Raynos for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @Raynos! 🎉

@Gpx
Copy link
Member

Gpx commented May 12, 2020

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gpx Gpx added the released label May 12, 2020
@Raynos
Copy link
Contributor Author

Raynos commented May 12, 2020

@kentcdodds @Gpx

You guys are amazing and super responsive. This is fantastic code maintenance.

@Raynos
Copy link
Contributor Author

Raynos commented May 13, 2020

Forgot to add the type definition in the types file ( #271 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants