Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of npm package by 99% #273

Merged
merged 2 commits into from May 13, 2020
Merged

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented May 13, 2020

There exists a 12MB binary in the tarball published to npm called cc-test-reporter.

This looks like a happy accident to me. It's only neccessary on the CI machine and should be removed before publishing the library.

The npm tarball for user-event is 12.9MB ; of which 12.8MB is this cc-test-reporter binary.

There exists a 12MB binary in the tarball published to npm called `cc-test-reporter`.

This looks like a happy accident to me. It's only neccessary on the CI machine and should be removed before publishing the library.
@Raynos
Copy link
Contributor Author

Raynos commented May 13, 2020

Travis failed because of 429 rate limiting on github when trying to git clone the source code.

@kentcdodds
Copy link
Member

Thanks for this! I think this repo is due for some tooling improvements which I plan to make soon, but I'll get this merged now to fix this issue right now.

@kentcdodds kentcdodds merged commit e2b5434 into testing-library:master May 13, 2020
@Gpx
Copy link
Member

Gpx commented May 13, 2020

🎉 This PR is included in version 10.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gpx Gpx added the released label May 13, 2020
@Raynos
Copy link
Contributor Author

Raynos commented May 13, 2020

Npm says the tarball is now 112kb and not 12.9mb

Thanks !

@kentcdodds
Copy link
Member

Hooray! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants