fix(upload): FileList item function must return null instead undefined when it can't find a file #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimshvetsov
commented
May 20, 2020
| target: { files: { item: () => {}, length: 0 } }, | ||
| }); | ||
|
|
||
| expect(input.files[0]).toBeUndefined(); |
There was a problem hiding this comment.
This tests do nothing special to user-event library. They only checks that fireEvent function works properly.
|
🎉 This PR is included in version 10.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at
FileListimplementation and noted thatitemfunction must returnFileornullinsteadundefined. Here isjsdomimplementation of it. Also fix wrong expectation in test that's not cause an error when it must. Also I removed unnecessary expectations inuploadtests.