Fire mouse events with the correct properties #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 98.76% 98.90% +0.13%
==========================================
Files 1 1
Lines 162 182 +20
Branches 46 55 +9
==========================================
+ Hits 160 180 +20
Misses 2 2
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This ensures that all mouse events are fired with the correct values for the button, buttons, and detail properties. This emulates what a browser would do, and is important for code that relies on this behavior. In addition, it should be possible to pass custom properties through to all events (e.g.
altKey, and screen positions).Why:
Tests should simulate how a browser fires them as closely as possible.
How:
Looked at the spec for each property and emulated the required behavior. Also tested in a real application that relies on some of them.
By default,
clickanddblClicksimulate the left mouse button. However, you can set thebuttonorbuttonsproperty when firing the event to override this. user-event will handle mapping the one that's set to the alternative one if unset, so it's consistent no matter which is specified.In addition, the
detailproperty is set according to the number of clicks that have occurred.Checklist:
Thanks for the great library! 馃槏