fix(type): wrap type in the asyncWrapper from DOM Testing Library #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with act warnings when using `type` with React Testing Library.
BREAKING CHANGE: The latest version of DOM Testing Library is required
Codecov Report
@@ Coverage Diff @@
## next #303 +/- ##
==========================================
+ Coverage 98.90% 98.91% +0.01%
==========================================
Files 1 1
Lines 182 185 +3
Branches 56 55 -1
==========================================
+ Hits 180 183 +3
Misses 2 2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Meemaw
added a commit
to Meemaw/user-event
that referenced
this pull request
Jun 2, 2020
…rary (testing-library#303)" This reverts commit 9fe76b4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: wrap
typein the asyncWrapper from DOM Testing LibraryWhy:
This fixes issues with act warnings when using
typewith React Testing Library (I expect the same would be necessary for angular change detection).How: Upgrade to the latest version of DOM Testing Library (it is now required) so we can get the
getConfigexport to use theasyncWrapper.Checklist:
BREAKING CHANGE: The DOM Testing Library version 7.9.0 or greater is required