feat(type): replace selected text #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kayleighridd would you mind reviewing this, too? I don't think I broke your recent work (tests pass), but another set of eyes wouldn't hurt if you have the time. 🙂 Thanks. |
|
I'm actively working on this right now (https://kcd.im/discord). I'll see if I can merge your PR, but I'm making some significant changes to how type works. |
|
Oh! Okay. |
kentcdodds
added a commit
that referenced
this pull request
Jun 4, 2020
4 tasks
kentcdodds
added a commit
that referenced
this pull request
Jun 4, 2020
|
🎉 This issue has been resolved in version 11.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #301
What: allowing
typeto replace selected textWhy: currently,
typealways appends to the end of the current value (ignoring selected text, which is replaced when a real user starts typing in the browser)How: check for
element.selectionEnd > element.selectionEndand replace that segment instead of appendingChecklist:
@kentcdodds This change (as currently implemented) breaks the ESLint complexity threshold (clocks in at 15 when the limit is 14). Do we need to simplify it somehow, adjust the rule, disable the rule, other?
Thanks.