Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): handle selectionRange properly #313

Merged
merged 1 commit into from Jun 5, 2020
Merged

Conversation

kentcdodds
Copy link
Member

What: fix(type): handle selectionRange properly

Why: Closes #309

How: create a new calculateNewBackspaceValue out of the calculateNewValue function because there's no reasonable way to abstract that. I promise.

Checklist:

  • Documentation N/A
  • Tests
  • Typings N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #313 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   99.26%   99.31%   +0.05%     
==========================================
  Files           2        2              
  Lines         273      293      +20     
  Branches       70       74       +4     
==========================================
+ Hits          271      291      +20     
  Misses          2        2              
Impacted Files Coverage Δ
src/type.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a6c3a...ea7bb03. Read the comment docs.

@kentcdodds kentcdodds merged commit 5c11411 into master Jun 5, 2020
@kentcdodds kentcdodds deleted the pr/fix-type-bugs branch June 5, 2020 18:02
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 11.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to v11.1.0 causes type method to fill Input incorrectly
1 participant