Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): allow typing negative numbers #338

Merged
merged 1 commit into from Jun 10, 2020
Merged

Conversation

kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Jun 10, 2020

What: Fixes issues with typing in number inputs

Why: Closes #336

How:

Checklist:

  • Documentation N/A
  • Tests
  • Typings N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #338 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   99.39%   99.41%   +0.01%     
==========================================
  Files           2        2              
  Lines         331      341      +10     
  Branches       84       87       +3     
==========================================
+ Hits          329      339      +10     
  Misses          2        2              
Impacted Files Coverage Δ
src/type.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4678d9...fb83941. Read the comment docs.

@kentcdodds kentcdodds merged commit 8156991 into master Jun 10, 2020
@kentcdodds kentcdodds deleted the pr/type-negative-number branch June 10, 2020 19:12
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 11.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use type() to type a "-" (minus) into a numeric input (type="number")
1 participant