Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move contributions to dom-testing-library #345

Merged
merged 1 commit into from Jun 15, 2020

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Jun 15, 2020

What: Move contributions to dom-testing-library

Why: To reduce churn so there's less work for us and pull request authors to do to migrate issues to dom-testing-library

How: Updated readme, contributing, issues, and pull requests documentation (no code changes or deprecations)

Checklist:

  • Documentation
  • Tests N/A
  • Typings N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           2        2           
  Lines         349      349           
  Branches       89       89           
=======================================
  Hits          347      347           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1c8d3...36d2a26. Read the comment docs.

@nickmccurdy nickmccurdy removed the request for review from kentcdodds June 15, 2020 01:20
@nickmccurdy nickmccurdy merged commit 6203cc7 into master Jun 15, 2020
@nickmccurdy nickmccurdy deleted the pr/move-contributions-to-dom-testing-library branch June 15, 2020 01:20
@nickmccurdy
Copy link
Member Author

nickmccurdy commented Jun 15, 2020

@kentcdodds I decided to just merge this so there's less of a chance of someone making a PR here accidentally, only to realize they have to rewrite it for dom-testing-library. If you don't like the wording I'd still be happy to update or revert it with your feedback.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid 👍

@kentcdodds
Copy link
Member

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants