Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make several API and implementation improvements #348

Merged
merged 7 commits into from Jun 15, 2020

Conversation

kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Jun 15, 2020

What: make several API and implementation improvements

Why: I was going to merge user-event into DOM Testing Library core (read more in testing-library/dom-testing-library#616), but unfortunately hit a ship stopping snag. So instead, I'm backporting my improvements and we're not going to merge the projects at this time.

How: ugh, way too much to describe 馃槵

Checklist:

  • Documentation
  • Tests
  • Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #348 into master will increase coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #348      +/-   ##
===========================================
+ Coverage   99.42%   100.00%   +0.57%     
===========================================
  Files           2        12      +10     
  Lines         349       374      +25     
  Branches       89       108      +19     
===========================================
+ Hits          347       374      +27     
+ Misses          2         0       -2     
Impacted Files Coverage 螖
src/index.js 100.00% <酶> (+0.97%) 猬嗭笍
src/blur.js 100.00% <100.00%> (酶)
src/clear.js 100.00% <100.00%> (酶)
src/click.js 100.00% <100.00%> (酶)
src/focus.js 100.00% <100.00%> (酶)
src/hover.js 100.00% <100.00%> (酶)
src/paste.js 100.00% <100.00%> (酶)
src/select-options.js 100.00% <100.00%> (酶)
src/tab.js 100.00% <100.00%> (酶)
src/type.js 100.00% <100.00%> (酶)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 136ac13...e13df95. Read the comment docs.

@kentcdodds kentcdodds changed the title feat: make several API and implmenetation improvements feat: make several API and implementation improvements Jun 15, 2020
@kentcdodds kentcdodds merged commit b8a274f into master Jun 15, 2020
@kentcdodds kentcdodds deleted the pr/big-changes branch June 15, 2020 21:53
kentcdodds added a commit that referenced this pull request Jun 15, 2020
BREAKING CHANGE: Remove `allAtOnce` option in favor of `delay: 0` or `paste` event
BREAKING CHANGE: Make `hover` and `unhover` sync
BREAKING CHANGE: Remove `toggleSelectedOptions` in favor of `deselectOptions`
BREAKING CHANGE: (Potentially...) improve correctness of all APIs (so we fire some additional events and improve general correctness). This may or may not break your usage depending on whether you relied on our in-correctness 馃槄
BREAKING CHANGE: `type` now *actually* defaults the `delay` to `0`, so it's not necessarily `async` anymore. It's only async if you pass a `delay`.
@kentcdodds
Copy link
Member Author

馃帀 This PR is included in version 12.0.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant