Replace type allAtOnce with "paste"

[kentcdodds]

It's not aligned with the goals of this lib, but the use case is understandable so we should include a simple "paste" event.

[rbusquet]

Is this a placeholder for a task you already started? I would appreciate it if I could grab this one. Thanks!

[kentcdodds]

This will be a breaking change and I'm not sure we're ready for it quite yet. But I can let you know when we are! In fact, if you want, you can go ahead and open a PR right now, you'll just have to keep it updated until we're ready to do it.

…

--- original message --- On Fri, Jun 5 at 09:43 PM, <notifications@github.com> Ricardo Busquet wrote: Is this a placeholder for a task you already started? I would appreciate if I could grab this one. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. --- end of original message ---

[weyert]

What would be the use case of this? Wouldn’t this be a different use case from typing? I have to admit I never use allAtOnce=true

[kentcdodds]

Yes, it's a different use case. allAtOnce shouldn't exist.

[weyert]

Ah right, that makes sense, wouldn't making a paste-action make more sense? Similar to clear or the upload actions that are available. I think I added the delay a long time ago so I don't mind that the allAtOnce option gets removed :)

[kentcdodds]

Yeah, that's the point of this issue 😉

[rbusquet]

went through a rabbit hole here. Would it be expected that this event would trigger onpaste event listeners? And what about other clipboard functionalities?

Already learned a lot, I'll continue investigating, but I'm kind of stuck in the lack of support for the clipboard API on jsdom (if we go down the path of dispatching clipboard events). Learning how browsers behave in these cases and how to mock them has been really interesting though.

[kentcdodds]

The goal would be that we fire every event that would be fired in the browser when a user pastes text on an element (including focusing that input).

[nickmccurdy]

• Extract paste event from old code for type's allAtOnce option
• Implement clipboardData support upstream Support clipboardData like dataTransfer. dom-testing-library#585
• Add events
  • paste with clipboardData
  • input with matching value
  • focus
• DataTransfer mock objects
  • Consider using in upstream tests

[nickmccurdy]

@rbusquet I think I figured this out mostly, but if you want to experiment/learn about paste events I have a playground

[rbusquet]

@nickmccurdy thanks! Yeah, I figured I would need more research, thanks for picking this one up.

[nickmccurdy]

This was partially implemented in #348 (which was ported from testing-library/dom-testing-library#645), but I still have some more work in progress from the todo list. I'll close this when I either fix the todos or extract them into separate issues.

[ph-fritsche]

The initial issue seems to be resolved.
Extended support for paste events as well as simulating the Clipboard API for environments (jsdom) not implementing it might be worth discussing in a new issue.
If anyone could collect the necessary information about the necessary changes in a new issue, that would be great. 🚀