Add else block to setSelectionRange check #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 376 383 +7
Branches 109 111 +2
=========================================
+ Hits 376 383 +7
Continue to review full report at Codecov.
|
nickmccurdy
approved these changes
Jun 21, 2020
kentcdodds
approved these changes
Jun 21, 2020
|
@all-contributors please add @WretchedDade for code and tests |
|
I've put up a pull request to add @WretchedDade! 🎉 |
|
🎉 This PR is included in version 12.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Awesome! Thanks ya'll! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes #369
Why:
Without this change, when a value is changed programatically as part of a React onChange event, the selectionRange stays at (0, 0) causing the values to be typed in reverse order.
How:
Added an else block to the
setSelectionRangefunction that is part oftype. The conditional already existed to check to see if the value changed programatically and my else adds logic to move the selection range to the end of the input to mimic the behavior of the browser.Checklist:
I attempted to replicate my failing react testing here by using the same format function and setting
event.target.valuewhen the input event fired. However, the test passed without my change. This leads me to believe that it is a symptom of how the value of an input is controlled by React. To confirm this fixed my issue I had to do the following:npm run builddist/type.jsto my React project'snode_modules/@testing-library/user-event/dist/type.jsfile.