Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leading number being trimmed on point type #376

Merged
merged 1 commit into from Jun 21, 2020
Merged

Fix leading number being trimmed on point type #376

merged 1 commit into from Jun 21, 2020

Conversation

lourenci
Copy link
Collaborator

@lourenci lourenci commented Jun 21, 2020

What:

It solves #360.

How:

In the actual code handling the point, I concatenate the input's previous value.
I tried to keep the changes as little as possible once I'm not used to neither to the events nor to the lib.

Checklist:

  • Documentation
  • Tests
  • Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #376   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          376       385    +9     
  Branches       109       111    +2     
=========================================
+ Hits           376       385    +9     
Impacted Files Coverage Δ
src/type.js 100.00% <100.00%> (ø)
src/tab.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce9dab...801688f. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! Thank you 👏

@kentcdodds kentcdodds merged commit 1ddadbd into testing-library:master Jun 21, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @lourenci for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @lourenci! 🎉

@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kentcdodds
Copy link
Member

🎉 This PR is included in version 12.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lourenci lourenci deleted the fix-point-removing-leading-values branch June 21, 2020 20:29
@lourenci
Copy link
Collaborator Author

lourenci commented Jun 21, 2020

Thanks so much for your help! I've added you as a collaborator on the project.

Thank you so much for this. I'll try to help the community as much as I can.

My next step is to become a member of the @testing-library org. 😊

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants