fix: do not wrap the whole function in the event wrapper #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
pr/fix-event-wrapper
branch
from
479e85b
to
95e5eb2
Compare
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 403 390 -13
Branches 111 111
=========================================
- Hits 403 390 -13
Continue to review full report at Codecov.
|
|
Verified locally that this does indeed fix the bug #387 |
|
@all-contributors please add @nasdan for bugs |
|
I've put up a pull request to add @nasdan! 🎉 |
|
🎉 This PR is included in version 12.0.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: do not wrap the whole function in the event wrapper
Why: Closes #387
How: Remove the
wrapInEventWrapperutility and use a simple event wrapper instead.Checklist:
- [ ] Documentation N/A- [ ] Tests N/A- [ ] Typings N/A