New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 407 type on no value elements #414
Fix 407 type on no value elements #414
Conversation
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 418 413 -5
Branches 116 116
=========================================
- Hits 418 413 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Just one question.
I think that we are missing one thing. We should enable modifiers on |
Good point. In fact, I think most events should not be fired on elements that aren't focusable. That said, I don't think the events will be fired on non-focusable elements anyway because we don't fire them on the given element, we fire them on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid. Thank you!
🎉 This PR is included in version 12.0.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Closes #407
Why:
Because typing on focusable elements should be possible without getting an error.
How:
Checked if an element has a value prop before handling input and selection on it.
Checklist: