Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): fire input event when files change (#574) #575

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Do not fire an input event if the user selects the same files again.
Do fire an input event if the user selects no files when files have been selected before.

Why:

See #574

How:

Compare the files provided by the user with input.files.

Checklist:

  • N/A Documentation
  • Tests
  • N/A Typings
  • Ready to be merged

@ph-fritsche
Copy link
Member Author

@schoeneu

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #575 (96b2b96) into master (8ef481f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #575   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          717       719    +2     
  Branches       226       228    +2     
=========================================
+ Hits           717       719    +2     
Impacted Files Coverage Δ
src/upload.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef481f...289264e. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 4e48750 into master Mar 9, 2021
@ph-fritsche ph-fritsche deleted the fix-574 branch March 9, 2021 11:22
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 This PR is included in version 12.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 9, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant