fix(keyboard): trigger onChange in React #626
Merged
+65
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Change element properties while hiding the change from React.
Why:
Closes #624
How:
React keeps track of properties by replacing the PropertyDescriptor.
We replace the PropertyDescriptor with the native one before setting the property and reapply React's PropertyDescriptor afterwards.
This way React should detect the value on the
input
event as a new value and dispatch aSyntheticEvent
foronChange
.Checklist: