fix(type): catch internal promise rejections #635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix UncaughtPromiseRejectionWarning for synchronous
userEvent.type()
that previously slipped through out catch.Promise rejections are reported per
console.error
.Asynchronous calls remain unaffected. Users can and have to handle promise rejections themselves.
Also includes an improved error message for undefined characters and adds test coverage for the error messages.
Why:
Close #633
How:
Return
the internal promise if it is notawait
ed.Checklist: