Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove deprecated keyboard features #780

Merged
merged 2 commits into from
Nov 15, 2021
Merged

fix!: remove deprecated keyboard features #780

merged 2 commits into from
Nov 15, 2021
+614 −724

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Nov 13, 2021 •
edited
Loading

What:

Remove deprecated features of old type implementation.

Why:

Closes #702

How:

  • Remove specialChars
  • Remove keyCode

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Additional information

Based on #779 which unblocks the removal of {selectall}

Remaining keyboardState.carryValue is internal and can be removed in a refactor once behavior plugins for time and date input are rewritten.

Sorry, something went wrong.

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Nov 13, 2021
@ph-fritsche ph-fritsche linked an issue Nov 13, 2021 that may be closed by this pull request
Deprecate and remove legacy type features #702
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0354e28:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Nov 13, 2021 •
edited
Loading

Codecov Report

Merging #780 (9007632) into alpha (b542540) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9007632 differs from pull request most recent head 0354e28. Consider uploading reports for the commit 0354e28 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #780   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        64    -1     
  Lines         1403      1394    -9     
  Branches       549       545    -4     
=========================================
- Hits          1403      1394    -9
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/keyboard/getEventProps.ts 100.00% <ø> (ø)
src/keyboard/index.ts 100.00% <ø> (ø)
src/keyboard/keyMap.ts 100.00% <ø> (ø)
src/keyboard/plugins/index.ts 100.00% <ø> (ø)
src/clear.ts 100.00% <100.00%> (ø)
src/keyboard/keyboardImplementation.ts 100.00% <100.00%> (ø)
src/keyboard/plugins/character.ts 100.00% <100.00%> (ø)
src/utils/edit/calculateNewValue.ts 100.00% <100.00%> (ø)
src/utils/edit/editInputElement.ts 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b542540...0354e28. Read the comment docs.

@ph-fritsche
fix!: remove specialChars
3c67ea0 
BREAKING CHANGE: Behavior for special key descriptor `{selectall}` has been removed.
@ph-fritsche
fix!: remove keyCode
0354e28 
BREAKING CHANGE: Support for `keyCode` property on keyboard events has been removed.
@ph-fritsche ph-fritsche marked this pull request as ready for review November 15, 2021 08:30
@ph-fritsche ph-fritsche merged commit 826cb63 into alpha Nov 15, 2021
@ph-fritsche ph-fritsche deleted the deprecated branch November 15, 2021 08:31
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ph-fritsche ph-fritsche mentioned this pull request Nov 15, 2021
Merged
3 tasks
ph-fritsche added a commit that referenced this pull request Nov 28, 2021
@ph-fritsche
fix!: remove deprecated keyboard features (#780)
45dc39a 
* fix!: remove `specialChars`

* fix!: remove `keyCode`

BREAKING CHANGE: Behavior for special key descriptor `{selectall}` has been removed.

BREAKING CHANGE: Support for `keyCode` property on keyboard events has been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
userEvent v14
Development

Successfully merging this pull request may close these issues.

Deprecate and remove legacy type features
1 participant
@ph-fritsche