feat!: remove support for user provided MouseEventInit
#784
+45
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `init` parameter has been removed from these APIs: - `userEvent.click` - `userEvent.dblClick` - `userEvent.tripleClick` - `userEvent.hover` - `userEvent.unhover` - `userEvent.selectOptions` - `userEvent.deselectOptions` BREAKING CHANGE: `userEvent.upload` no longer supports `clickInit` as part of its `init` parameter.
ph-fritsche
force-pushed
the
remove-init
branch
from
6dd2605 to
3720704
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3720704:
|
Codecov Report
@@ Coverage Diff @@
## alpha #784 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 1394 1393 -1
Branches 545 544 -1
=========================================
- Hits 1394 1393 -1
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Nov 16, 2021
|
🎉 This PR is included in version 14.0.0-alpha.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
ph-fritsche
added a commit
that referenced
this pull request
Nov 28, 2021
BREAKING CHANGE: `init` parameter has been removed from these APIs: - `userEvent.click` - `userEvent.dblClick` - `userEvent.tripleClick` - `userEvent.hover` - `userEvent.unhover` - `userEvent.selectOptions` - `userEvent.deselectOptions` BREAKING CHANGE: `userEvent.upload` no longer supports `clickInit` as part of its `init` parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
initparameter has been removed from these APIs:userEvent.clickuserEvent.dblClickuserEvent.tripleClickuserEvent.hoveruserEvent.unhoveruserEvent.selectOptionsuserEvent.deselectOptionsBREAKING CHANGE:
userEvent.uploadno longer supportsclickInitas part of its
initparameter.What:
Remove
initparameters forEventInitof mouse/pointer events.Why:
The
initparameters are escape hatches.They were used for different events that don't necessarily share the same properties.
The new pointer implementation renders supplying own
MouseEventInitproperties obsolete as the events are created according to specs / living standard.If our code lacks non-deprecated features from the specs, we should add them.
If our users want to test features outside of the specs, they should be on their own using lower level implementations.
The
initparameter encourages bad practice as it makes it convenient to just tweak the events instead of describing a user interaction that might lead up to those events.Checklist: