New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use globalThis instead of global for browser support #928
fix: use globalThis instead of global for browser support #928
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 35cb049:
|
Codecov Report
@@ Coverage Diff @@
## main #928 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 85
Lines 1785 1785
Branches 641 641
=========================================
Hits 1785 1785
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to this library ❤️
Thanks for your amazing work in this library ❤️ |
@all-contributors add @yannbf code |
I've put up a pull request to add @yannbf! 🎉 |
🎉 This PR is included in version 14.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
This PR fixes a regression introduced here
Why:
At Storybook we have a package @storybook/testing-library which we use user-event and we'd love to upgrade to v14, but until browser support is sorted we have to hold off.
How:
This PR changes a reference from
global
toglobalThis
to enable browser support.Checklist: